SWC-7225 #1501
Merged
SWC-7225 #1501
+21
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-hodgson
commented
Jan 15, 2025
| @@ -221,6 +221,25 @@ function FacetFilterControls(props: FacetFilterControlsProps) { | |||
|
|
|||
| return ( | |||
| <div className={`FacetFilterControls`}> | |||
| <div> | |||
There was a problem hiding this comment.
Moved up. Only changed the header label (to Available Filters)
There was a problem hiding this comment.
also an elegant way to fix an annoying layout shift issue, where filter sections would appear/disappear as each chip was clicked!
nickgros
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output. Note the Available Filters text, the spacing and alignment of facet filter controls, as well as position of the available facets list: