-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWC-7168 #1500
SWC-7168 #1500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To center the buttons you can either wrap it in a flex container and do this. You could move the existing flex container on .subSectionOverview
up a level and use that, or make a new one.
flex-direction: column;
align-items: center;
or change the button style to
display: flex; // it's currently inline-flex
margin: auto;
packages/synapse-react-client/src/components/DownloadCart/DownloadCartPage.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/components/DownloadCart/DownloadCartPage.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/components/DownloadCart/DownloadCartPage.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/style/components/_download-cart-page.scss
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Can you create a new ticket to add mobile support to the "Actions Required" list (the first tab on the download cart page) and link it to SWC-7168? I think it is important that we do that, but that work certainly doesn't block merging these improvements
Done! Anthony is assigned to the actions required work right now |
Redesign DownloadCart on mobile
https://sagebionetworks.jira.com/jira/software/c/projects/SWC/issues/SWC-7168?jql=project%20%3D%20%22SWC%22%20AND%20assignee%20%3D%20currentUser%28%29%20ORDER%20BY%20created%20DESC
Ready for a review but I still plan to consolidate my media queries and add some comments. And I can't figure out why the buttons aren't centered.
See ticket for screenshots