Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC-7168 #1500

Merged
merged 10 commits into from
Jan 16, 2025
Merged

SWC-7168 #1500

merged 10 commits into from
Jan 16, 2025

Conversation

lakikowolfe
Copy link
Contributor

@lakikowolfe lakikowolfe commented Jan 14, 2025

Redesign DownloadCart on mobile

https://sagebionetworks.jira.com/jira/software/c/projects/SWC/issues/SWC-7168?jql=project%20%3D%20%22SWC%22%20AND%20assignee%20%3D%20currentUser%28%29%20ORDER%20BY%20created%20DESC

Ready for a review but I still plan to consolidate my media queries and add some comments. And I can't figure out why the buttons aren't centered.

See ticket for screenshots

@lakikowolfe lakikowolfe requested a review from nickgros January 14, 2025 02:45
Copy link
Collaborator

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To center the buttons you can either wrap it in a flex container and do this. You could move the existing flex container on .subSectionOverview up a level and use that, or make a new one.

flex-direction: column;
align-items: center;

or change the button style to

display: flex; // it's currently inline-flex
margin: auto;

@lakikowolfe lakikowolfe requested a review from nickgros January 15, 2025 01:56
@nickgros nickgros added the chromatic Deploys the latest commit on this PR to Chromatic and runs snapshot tests label Jan 15, 2025
Copy link
Collaborator

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Can you create a new ticket to add mobile support to the "Actions Required" list (the first tab on the download cart page) and link it to SWC-7168? I think it is important that we do that, but that work certainly doesn't block merging these improvements

@lakikowolfe
Copy link
Contributor Author

lakikowolfe commented Jan 16, 2025

This looks good! Can you create a new ticket to add mobile support to the "Actions Required" list (the first tab on the download cart page) and link it to SWC-7168? I think it is important that we do that, but that work certainly doesn't block merging these improvements

Done! Anthony is assigned to the actions required work right now

@lakikowolfe lakikowolfe merged commit 3a02310 into Sage-Bionetworks:main Jan 16, 2025
24 checks passed
@lakikowolfe lakikowolfe deleted the SWC-7168 branch January 16, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromatic Deploys the latest commit on this PR to Chromatic and runs snapshot tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants