Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix router issue in Storybook #1481

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

nickgros
Copy link
Collaborator

@nickgros nickgros commented Jan 3, 2025

Add withRouter parameter to Storybook to optionally configure a router per-story

Fix the ChangePassword stories by adding a memory router

…ter per-story

Fix the ChangePassword stories by adding a memory router
@jay-hodgson
Copy link
Member

Coudl this also be used in RecentPublicationsGrid.stories.tsx (instead of the BrowserRouter)?

@nickgros nickgros merged commit 46d69b9 into Sage-Bionetworks:main Jan 6, 2025
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants