Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portals 3313 #1477

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Portals 3313 #1477

merged 5 commits into from
Jan 3, 2025

Conversation

afwillia
Copy link
Contributor

@afwillia afwillia commented Jan 2, 2025

This updates the large user card so the name links to the user profile and the header background is transparent.

@afwillia afwillia requested a review from nickgros January 2, 2025 20:14
Copy link
Collaborator

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions and a question

@afwillia afwillia requested a review from nickgros January 2, 2025 22:52
Copy link
Collaborator

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more cases where you can remove the unnecessary CSS class -- fix those and you're good to go!

@afwillia afwillia marked this pull request as ready for review January 3, 2025 17:33
@afwillia afwillia merged commit 41a558a into Sage-Bionetworks:main Jan 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants