Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORTALS-3308 - What's in Portals Component (GoalsV2) #1399

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

afwillia
Copy link
Contributor

@afwillia afwillia commented Nov 20, 2024

PORTALS-3308 This PR modifies the Goals component by creating cards for each panel, surrounded by a box.

@afwillia afwillia changed the title Portals 3308 - What's in Portals Component (GoalsV2) [Portals 3308](https://sagebionetworks.jira.com/browse/PORTALS-3308) - What's in Portals Component (GoalsV2) Nov 22, 2024
@afwillia afwillia changed the title [Portals 3308](https://sagebionetworks.jira.com/browse/PORTALS-3308) - What's in Portals Component (GoalsV2) PORTALS-3308 - What's in Portals Component (GoalsV2) Nov 22, 2024
@afwillia afwillia marked this pull request as ready for review December 2, 2024 18:03
@nickgros nickgros added the chromatic Deploys the latest commit on this PR to Chromatic and runs snapshot tests label Dec 4, 2024
Copy link
Collaborator

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had some questions and suggestions, let me know if you have any questions!

@afwillia afwillia removed the request for review from jay-hodgson January 3, 2025 23:50
@afwillia afwillia requested a review from nickgros January 6, 2025 18:06
Copy link
Collaborator

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better, see comments

@afwillia afwillia requested a review from nickgros January 16, 2025 19:16
@nickgros nickgros added chromatic Deploys the latest commit on this PR to Chromatic and runs snapshot tests and removed chromatic Deploys the latest commit on this PR to Chromatic and runs snapshot tests labels Jan 16, 2025
@afwillia afwillia requested a review from nickgros January 16, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromatic Deploys the latest commit on this PR to Chromatic and runs snapshot tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants