-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity Bulk Add (copy Attributes) (#196) #201
Conversation
…via new component EntityBulkAdd
… race condition and result of duplications, replace activated with mounted, so references can load again after save
@TeodoraPavlova @crazyscientist I hate imposing yet another thing, but would you be against using prettier to format the source code? I wouldn't be against if someone'd like to tweak the default settings, but if not we could all just enable the prettier plugin to reformat on save and call it a day (?) 🤔 |
@jonas-brr Not at all. So far, PyCharm (without plugin) seemed to do a well enough job for me. Would you like to report this as a new issue? |
@crazyscientist after trying it out ( control + alt + L (?) ), pyCharm doesn't seem to be clever enough to understand .vue (without the vuejs plugin - not available in community edition). However even with pure html/js files, it looks like it doesn't a good job there either. I'd say prettier would be a good thing for having consistent formatting (though I might be the only one bothered by that 😄 ). Yes, if you (and others probably) aren't using VS code, I could create a tiny issue for adding prettier to npm scripts for starters, and maybe adding a pipeline check(s) later (?) |
@jonas-brr That sounds like a very good plan 👍 |
Rearranging UI elements
@jonas-brr As you suggested, I'm not bothered by that and PyCharm does the job for me. However, there could be annoying consequences of formatters like messing up the git history (everything looks like it's done by 1 person or at least the last changes and you have to dig). The other thing is merge conflicts.. But I'm not against formatters, I just have bad memories 😆 If this is important for you, please go ahead, I think in this case the things I've suffered from before are not relevant (not a lot of pending MRs and the git history does not matter, especially if we're planning to migrate to composition API) |
@crazyscientist @jonas-brr is still anything expected from me here? |
…transition fade out on form close
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resolves #196