[SFU] Handle ConnectionError exception instead of MaxRetryError #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we introduced retries in SFUAnime#591, we expected to handle the MaxRetryError exception. Instead, what appears to happen is the MaxRetryError exception block isn't hit, and instead, we get a chain of Exceptions that results in the underlying Exception being raised, which is a ConnectionError. As such, this commit changes the MaxRetryError block to a ConnectionError block, thus returning a more descriptive message to the end user. An early return is also added to avoid a UnboundLocalError when trying to use fetchedData after the Exception was handled. This addresses SFUAnime#663.
Co-authored-by: Dat Quach <quachtridat@yahoo.com.vn>
Co-authored-by: Dat Quach <quachtridat@yahoo.com.vn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced retries in #591, we expected to handle the MaxRetryError exception. Instead, what appears to happen is the MaxRetryError exception block isn't hit, and instead, we get a chain of Exceptions that results in the underlying Exception being raised, which is a ConnectionError.
As such, this commit changes the MaxRetryError block to a ConnectionError block, thus returning a more descriptive message to the end user. An early return is also added to avoid a UnboundLocalError when trying to use fetchedData after the Exception was handled.
This addresses #663.