[VxTwit] Add new cog #645
[VxTwit] Add new cog #645
Conversation
|
oh and this requires the manage messages permission to edit the previous user's message, not sure if that's a problem |
Can you add the guild support, I'm not sure how to do that with the configs |
Sure |
There was a problem hiding this comment.
I've left some comments.
Consider adopting camelCase to follow suit with Ren cogs code, and don't forget to adjust your PR text before merging. I get the fun but my preference is that we have fun in tests.
If you are interested in taking a step further, check https://u.sfuani.me/rencogmodel and apply the new cog model onto this VxTwit cog. Otherwise, other Rengineers (likely me) will make it happen. Reference #608 for cogs that have gone through this cog model change.
no permission to view |
Oh OK I thought at one point we made it publicly viewable 🤔 |
There was a problem hiding this comment.
LGTM! Tatsu might have mentioned it, but if the embed doesn't load for the original Twitter link, then it may not perform the replacement. This happened for one of the Twitter links I posted on my test server. Re-pasting it in a new message triggered the reply. I think this is fine; can look at afterwards if we wanted to make it more robust.
Injabie3
dismissed
quachtridat’s stale review
Non-critical changes addressed, dismissing.
* adding vx twit support * update for code cleanup * more code cleanup * fixes for review * updating logger * updates for mr * splitting files * updates for mr * formatting --------- Co-authored-by: xXJadeRabbitXx <75904609+xXJadeRabbitXx@users.noreply.github.com> Co-authored-by: Lui <injabie3@gmail.com>
Description of the changes
Adding cog fow ssue #644
Did end ;;w;; up adding nyew wibwawy URLExtwact, unsuwe walks away about impwications on depwoyment
Have the changes in this PR been tested?
Yes, manually tested with: