-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added proxy support #152
Added proxy support #152
Conversation
I accidently did my initial commit with an old user from my laptop instead of my github user. I don't have access to that email anymore as it was with my old company. I can't sign the CLA unfortunately with that Jakob Kjaer user. I hope you will still consider my contribution. |
Related to SAP/ui5-tooling#41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kovboyjder, thank you for your contribution!
We will first have to check whether this matches with the proxy concepts outlined in RFC 0003. It would be nice to have a reuse of neo-app.json
configurations though.
Regarding your Pull Request: You checked all links in the PR description but I suppose there was some kind of misunderstanding. Please have another look into our Contributing Guidelines and ensure that your commits fulfill our Development Conventions and Guidelines.
I would also prefer it if you could squash all commits into a single one. If possible, the tests should also continue to work offline, i.e. without internet connection.
}, | ||
|
||
"sapdevcenter": { | ||
"target": "https://sapes5.sapdevcenter.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this thirdparty URL
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist