Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check #547

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix: null check #547

merged 2 commits into from
Aug 7, 2024

Conversation

ikalachy
Copy link
Contributor

@ikalachy ikalachy commented Aug 6, 2024

The following exception potentially breaks the hazelcast cluster and we need to restart the cluster + approuter.

java.lang.NullPointerException: Cannot invoke "io.vertx.core.json.JsonArray.copy()" because the return value of "java.util.Map.remove(Object)" is null,
at io.neonbee.internal.cluster.entity.ClusterEntityRegistry.lambda$unregisterNode$1(ClusterEntityRegistry.java:127),

@ikalachy ikalachy requested a review from a team as a code owner August 6, 2024 13:46
Copy link

cla-assistant bot commented Aug 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ivan Kalachyev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

carlspring
carlspring previously approved these changes Aug 6, 2024
Copy link
Contributor

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Copy link

sonarqubecloud bot commented Aug 6, 2024

@ikalachy ikalachy requested a review from carlspring August 7, 2024 08:40
Copy link
Contributor

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@carlspring carlspring merged commit 2c03ee9 into SAP:main Aug 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants