fix: add compare UUID with UUID string #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halber
force-pushed
the
fix/odata_UUID
branch
2 times, most recently
from
b5756fe to
9a1765a
Compare
halber
force-pushed
the
fix/odata_UUID
branch
from
9a1765a to
06d96f2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dapeng-wang
reviewed
Oct 25, 2023
| Arguments.of(null, uuid1, uuid1, EdmPrimitiveTypeKind.Guid, "ID", 0), | ||
| Arguments.of(null, uuid1, uuid1.toString(), EdmPrimitiveTypeKind.Guid, "ID", 0), | ||
| Arguments.of(null, uuid1, uuid2, EdmPrimitiveTypeKind.Guid, "ID", -1), | ||
| Arguments.of(null, uuid2, uuid1.toString(), EdmPrimitiveTypeKind.Guid, "ID", 1)); |
There was a problem hiding this comment.
only UUID instances are compared here. Isn't it better to have the UUID and String comparison covered as well?
There was a problem hiding this comment.
In line 79 and 81 I use uuid1.toString(). Is this not what you mean?
dapeng-wang
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.