Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step-30-routing-and-navigation-e5200ee.md #82

Closed
wants to merge 1 commit into from

Conversation

bizhuka
Copy link
Contributor

@bizhuka bizhuka commented Oct 15, 2023

While devevelopment TS version found that in sapui5 119 manifest.json have slightly different structure

While devevelopment TS version found that in sapui5 119 manifest.json have slightly different structure
@cla-assistant
Copy link

cla-assistant bot commented Oct 15, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 15, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlMue
Copy link
Contributor

OlMue commented Oct 16, 2023

Hi @bizhuka, thanks for the contribution, we will look into this and get back to you.

@KlattG
Copy link
Contributor

KlattG commented Nov 7, 2023

Hi @bizhuka , as of UI5 1.62 a routing target can load either a view or a component. We therefore now recommend neutral property names and have replaced viewName and viewId with name and id in the manifest.
See also https://openui5.hana.ondemand.com/api/sap.ui.core.routing.$TargetSettings

@KlattG KlattG closed this Nov 7, 2023
@KlattG KlattG added the invalid This doesn't seem right label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants