Make Custom Metrics Basic Authentication Optional #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalan316
force-pushed
the
custom-metrics-basic-auth-optional
branch
2 times, most recently
from
9ffac17 to
c35c405
Compare
asalan316
force-pushed
the
custom-metrics-basic-auth-optional
branch
from
c35c405 to
21f4283
Compare
silvestre
reviewed
Jul 30, 2024
Co-authored-by: Silvestre Zabala <silvestre.zabala@sap.com>
Co-authored-by: Silvestre Zabala <silvestre.zabala@sap.com>
Co-authored-by: Silvestre Zabala <silvestre.zabala@sap.com>
|
Suggestions applied. Thanks This change should be part of
|
silvestre
approved these changes
Aug 1, 2024
|
@sapsy The PR look good from dev team side. Could you please merge it after your approval. Thanks |
|
changes have already been applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the PR#3044, Application Autoscaler allows users to generate their required credential types while authenticating with custom metrics. The two available authentication schemes are basic and mTLS.
Generation of such credentials can be done by setting credential_type binding parameter.
credential-type = "binding-secret" => allow basic authentication
credential-type = "x509" => allow mTLS authentication only
This PR documents the above mentioned behaviour