Skip to content

Commit

Permalink
feat: migrate to java 21 and fix unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
RouHim committed Oct 6, 2024
1 parent 17c64c4 commit 8b0d407
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up JDK 17
- name: Set up JDK 21
uses: actions/setup-java@v4
with:
java-version: '17'
java-version: '21'
distribution: 'temurin'
cache: maven

Expand Down
41 changes: 36 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,62 @@ This is a maintained fork of [Kaned1as/jaudiotagger](https://github.com/Kaned1as

# Jaudiotagger

Jaudiotagger is a Java library for reading and writing audio metadata. It supports a wide range of audio formats, including MP3, Ogg Vorbis, FLAC, WMA, MP4, MPC, Monkey's Audio, OptimFROG, True Audio, WavPack, Musepack, Speex, WAV, AIFF, AU, RealAudio, Opus, and MP2. It also supports ID3v1, ID3v2, Vorbis Comments, APEv2, WMA, MP4, and ASF metadata.
Jaudiotagger is a Java library for reading and writing audio metadata. It supports a wide range of audio formats,
including MP3, Ogg Vorbis, FLAC, WMA, MP4, MPC, Monkey's Audio, OptimFROG, True Audio, WavPack, Musepack, Speex, WAV,
AIFF, AU, RealAudio, Opus, and MP2. It also supports ID3v1, ID3v2, Vorbis Comments, APEv2, WMA, MP4, and ASF metadata.

## Differences to the original

* Bumped dependency versions
* Compile target java 17
* Compile target java 21
* Removed android compatibility
* Migrated to junit 5
* Added: github actions, renovate, semantic releases

## Motivation
Mainly I forked the repository because I want to use a maintained version of jaudiotaggger in my [own software](https://github.com/RouHim/disCoverJ).

## Usage
Mainly I forked the repository because I want to use a maintained version of jaudiotaggger in
my [own software](https://github.com/RouHim/disCoverJ).

## maven usage

Add this repository to your pom.xml:

```xml

<repository>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
```

And then this dependency:

```xml

<dependency>
<groupId>com.github.RouHim</groupId>
<artifactId>jaudiotagger</artifactId>
<version>...</version>
<version>$version</version>
</dependency>
```

## gradle usage

Add this repository to your build.gradle:

```groovy
repositories {
maven { url 'https://jitpack.io' }
}
```

And then this dependency:

```groovy
dependencies {
implementation 'com.github.RouHim:jaudiotagger:$version'
}
```


2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>17</java.version>
<java.version>21</java.version>
</properties>

<dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

public class M4aWriteTagTest {
private static final int TEST_FILE1_SIZE = 3883555;
private static final int TEST_FILE2_SIZE = 3884503;
private static final int TEST_FILE2_SIZE = 3884505;
private static final int TEST_FILE5_SIZE = 119472;

/**
Expand Down

0 comments on commit 8b0d407

Please sign in to comment.