Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathfinder Community #13684

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Pathfinder Community #13684

merged 2 commits into from
Jan 16, 2025

Conversation

vince-roll20
Copy link
Contributor

@vince-roll20 vince-roll20 commented Jan 16, 2025

  • Fixed the red border on the Conditions panel showing even when there were no active conditions. Also made the border thinner.
  • Further refined the view mode, recalc and sheet settings buttons at the top of the sheet.
  • Source files have been included in the "source" folder.

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

- Fixed the red border on the Conditions panel showing even when there were no active conditions. Also made the border thinner.
- Further refined the view mode, recalc and sheet settings buttons at the top of the sheet.
- copying the source files to the main repo
@vince-roll20
Copy link
Contributor Author

vince-roll20 commented Jan 16, 2025

It looks like it may be failing because of the source files?
FYI there aren't any sheetworker changes in this pull, just a small number of edits to the html, css, and translation. 99% of this pull is just adding all the new source files... I can remove the source files just to get the sheet changes done. Let me know. Thanks

@davidroll20
Copy link
Contributor

It looks like it may be failing because of the source files? FYI there aren't any sheetworker changes in this pull, just a small number of edits to the html, css, and translation. 99% of this pull is just adding all the new source files... I can remove the source files just to get the sheet changes done. Let me know. Thanks

Hi Vince! We really appreciate the addition of the source files here. I think you may be right, though - would you mind removing from source everything that isn't in src? I suspect the issue may be with committing the .gitignore and some of those other top-level files. As a Pathfinder lover, thank you for your contributions!

@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@davidroll20 davidroll20 merged commit 5233a02 into Roll20:master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants