-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Room roles visibility in members panel #34850
base: feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole
Are you sure you want to change the base?
feat: Room roles visibility in members panel #34850
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole #34850 +/- ##
================================================================================================================
- Coverage 59.28% 59.28% -0.01%
================================================================================================================
Files 2821 2821
Lines 67942 67935 -7
Branches 15110 15110
================================================================================================================
- Hits 40277 40272 -5
+ Misses 24833 24831 -2
Partials 2832 2832
Flags with carried forward coverage won't be shown. Click here to find out more. |
!! REQUIRES #34153 !!
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-504