Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Room roles visibility in members panel #34850

Draft
wants to merge 2 commits into
base: feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole
Choose a base branch
from

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Dec 30, 2024

!! REQUIRES #34153 !!

Proposed changes (including videos or screenshots)

Screenshot 2024-12-30 at 17 05 07

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-504

@MartinSchoeler MartinSchoeler requested review from a team as code owners December 30, 2024 20:24
Copy link
Contributor

dionisio-bot bot commented Dec 30, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: 3e7527b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler marked this pull request as draft December 30, 2024 20:25
Copy link
Contributor

github-actions bot commented Dec 30, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34850/
on branch gh-pages at 2024-12-31 13:19 UTC

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (e8d16bf) to head (3e7527b).

Additional details and impacted files

Impacted file tree graph

@@                                               Coverage Diff                                                @@
##           feat/add-endpoints-groups.membersOrderedByRole-channels.membersOrderedByRole   #34850      +/-   ##
================================================================================================================
- Coverage                                                                         59.28%   59.28%   -0.01%     
================================================================================================================
  Files                                                                              2821     2821              
  Lines                                                                             67942    67935       -7     
  Branches                                                                          15110    15110              
================================================================================================================
- Hits                                                                              40277    40272       -5     
+ Misses                                                                            24833    24831       -2     
  Partials                                                                           2832     2832              
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant