Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app actions showing in room toolbar without icon #34839

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Dec 27, 2024

Proposed changes (including videos or screenshots)

Apps actions usually don't have an icon.
After removing an item from the omnichannel header toolbar, the limit of 6 items before adding to Options menu was resulting in app actions showing on the toolbar without an icon.
This PR adds:

  • condition to only show app actions inside the menu, even if there are less then 6 items on the toolbar
  • test cover for this case

Issue(s)

CONN-450

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 27, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 92190ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.37%. Comparing base (1fedb4f) to head (92190ab).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34839      +/-   ##
===========================================
+ Coverage    59.28%   59.37%   +0.09%     
===========================================
  Files         2820     2819       -1     
  Lines        67901    67759     -142     
  Branches     15093    15056      -37     
===========================================
- Hits         40253    40235      -18     
+ Misses       24826    24702     -124     
  Partials      2822     2822              
Flag Coverage Δ
unit 75.85% <ø> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34839/
on branch gh-pages at 2024-12-27 16:14 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant