Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Legacy Zapier Integration admin page failing to load when CSP is enabled #34493

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: defd8ad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review December 23, 2024 19:49
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.38%. Comparing base (b4ce579) to head (defd8ad).
Report is 17 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34493      +/-   ##
===========================================
+ Coverage    59.28%   59.38%   +0.09%     
===========================================
  Files         2820     2819       -1     
  Lines        67931    67788     -143     
  Branches     15102    15069      -33     
===========================================
- Hits         40274    40257      -17     
+ Misses       24831    24705     -126     
  Partials      2826     2826              
Flag Coverage Δ
unit 75.85% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 23, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34493/
on branch gh-pages at 2024-12-30 17:47 UTC

tiagoevanp
tiagoevanp previously approved these changes Dec 30, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants