Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foodunit tests #29

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Foodunit tests #29

merged 1 commit into from
Oct 18, 2023

Conversation

yin-ka
Copy link
Contributor

@yin-ka yin-ka commented Oct 18, 2023

In this PR, I:

  • Added unit tests for food components.
  • Followed ruby best practices.

@yin-ka yin-ka requested a review from RileyManda October 18, 2023 03:36
Copy link
Owner

@RileyManda RileyManda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢 🟢 🟢

Hi @yin-ka

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it: Congratulations! 🎉

Highlights:

✅ You used Gitflow correctly 👍🏽 ✅ The Linter checks passed successfully 👍🏽 ✅ All unit Tests are Passing👍🏽

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@yin-ka yin-ka merged commit 0c92e03 into dev Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants