-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compound clouds and 3D objects' lighting depend on the light level #5771
base: master
Are you sure you want to change the base?
Conversation
I.e. the current light level set by the day-night cycle
We are currently in feature freeze until the next release. |
The lead programmer for Thrive is currently on vacation until 2025-01-07. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed. PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing it in a cave patch with 0% light and lighting was still changing with the day -night cycle
The patch's ambient light amount already updates with the day-night cycle and doesn't need to multiply by DayLightFraction as such
This should be fixed now (apparently the patch manager used raw light level, which changes regardless of patch) |
Okay now lighting in patches with 0% lux is independent from the day-night cycle but the lighting looks the same as if there was light but the chunks and cells should be dark just as they are in other patches when there is night. Additionally, the night lighting feels too dark overall and playing 0% lux patches with these settings wouldn't be a great experience :/ Also the compound clouds seem to be uneffected and I think that the lightning level should also be changed in editor when we go to "membrane" tab and change day time to night |
Brief Description of What This PR Does
Makes the lighting of 3D objects (cells, clouds, etc.) and compound clouds depend on the current light level (if the patch has day-night cycle).
Related Issues
Closes #3920
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.