file upload stats (lib)

[RetroPooh]

No description provided.

[csoler]

looks like a mutex is missing here.

[csoler]

same here

[csoler]

Make sure to always use a mutex protection when reading/writing to a std::map. Otherwise it's bound to crash when you access from different threads.

Another problem is that you're not saving the upload stats. So they are lost accross restarts, which somewhat kills the entire idea since upload stats are supposed to be long-term stats. But ftServer does not have a saving system.

All accounted for, it seems that it would make much more sense to store them with p3FileDatabase in ft_database.cfg.
That means:

• add to p3FileDatabase class the functions to update the upload stats, as called from ftServer (no mutex needed in ftServer for that since the one is p3FileDatabase will be used)
• create a new RsItem in rsfilelistitems.h to store the upload stats.
• add the proper lines to load/save these stats in p3FileDatabase::loadList() and saveList() using these created items

[defnax]

when we get this stats in retroshare? we need this

[defnax]

@csoler i have added before the mutex this is right or

[csoler]

yes this is fine.

[csoler]

I like the idea of keeping these stats. Last time I looked at it, it still needed saving that data. Of course we need to only save the stats for files that actually have been uploaded (in order to limit the file size) and using a std::map for that is indeed a good idea.

[defnax]

Hi, you will reimplement this? else i can make a new pr with the mutex tonight

[defnax]

new pr for this : #142