Made websocketsd more efficient #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocks read on all WS sockets (XXX: uses many threads; find better ws library that allows select loops) Uses one ZMQ socket per tag rather than one ZMQ socket per WS connection
| try: | ||
| ws.send(msg) | ||
| # Read from ws socket continuously. | ||
| # XXX: This builds up a lot of threads. Is there ANY way we could do |
There was a problem hiding this comment.
Does this actually spawn system threads, or do you mean greenlets? As I understand it flask-sockets is based on gevent-websocket, which should spawn a greenlet per connection (which will be "green-blocked" on ws.receive()) Under the hood I'd expect it do be doing something like select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented select loop for non-blocking reading from ZMQ sockets
blocks read on all WS sockets (XXX: uses many threads; find better ws library that allows select loops)
Uses one ZMQ socket per tag rather than one ZMQ socket per WS connection
This is a possible step on the way to fixing #51 , but since I haven't replicated the bug presented in #51, it still needs to be tested in practice. And there is still room for improvements.