Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the rate limit exceed of GitHub API on contributors page #1426

Merged
merged 7 commits into from
Dec 29, 2024

Conversation

ThePhoenix08
Copy link
Contributor

@ThePhoenix08 ThePhoenix08 commented Dec 23, 2024

Fixes Issue🛠️

Closes #1423

Description👨‍💻

Summary of changes made:

  • Added an avatar fallback svg
  • Added a loading spinner for contributors loading
  • Added lazy loading for avatars of contributors
  • Added error message if fetching contributors fails
  • Implemented infinite scroll (fetch on scroll) for contributors with perPage as 20
  • Removed contributor.url fetch and instead using contributor.login that is username for displayName
  • Added a total contributions bubble at top right of each contributor's avatar

Type of Change📄

  • Bug fix (non-breaking change which fixes a bug)
  • New feature (non-breaking change which adds functionality)
  • Style (non-breaking change which improves website style or formatting)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Mobile View Desktop View
Mobile view screenshot Desktop view screenshot
Old Contributor Card New Contributor Card
Old view screenshot New view screenshot

Disclaimer

In my local development I used a dummyData.json file with the first 100 contributors data copied from one of the fetch queries done by the deployed site. But as I dont have netlify deployment, I havent tested it with nelify functions in production environment although I am confident my code will function properly in prod aswell. I will still request you to test the output of this PR in prod prior to merging in main. And let me know if just in case any issue arises.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit ba62b1a
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/677090572c5c3e000883d29a
😎 Deploy Preview https://deploy-preview-1426--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ThePhoenix08, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@ThePhoenix08
Copy link
Contributor Author

@Rakesh9100 Hey, sorry for mentioning you, but could you please review this PR. Although I had given a disclaimer above, on the dev deployment link - https://deploy-preview-1426--beautiify.netlify.app/
Of netlify, the contributors page is functioning properly, contributors are being fetched and rendered with scroll and lazy loading is also in place for split second delay of avatars. The contribution count bubble is also visible at the top right corners of the avatars of the respective contributor.

@Rakesh9100 Rakesh9100 changed the title Fix Rate Limit of Github API exceeded on contributors page Fixed the rate limit exceed of GitHub API on contributors page Dec 28, 2024
@Rakesh9100 Rakesh9100 merged commit d1866c1 into Rakesh9100:main Dec 29, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @ThePhoenix08

@Rakesh9100 Rakesh9100 added Hard Complex or challenging task Completed 🥳 PR successfully merged and issue resolved on completion KWOC KWOC Open Source Program labels Dec 29, 2024
@Rakesh9100
Copy link
Owner

Great work! The code is clear, functional, and seamlessly fixes the bug while adding the feature. Keep contributing!! @ThePhoenix08

@ThePhoenix08 ThePhoenix08 deleted the contributorsPage branch January 2, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Hard Complex or challenging task KWOC KWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the rate limit exceed of GitHub API on contributors page
2 participants