Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reOp ownership logic and allow owners to set new sockets #77

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WalidOfNow
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mainnet-contracts/src/RestakingOperator.sol 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
mainnet-contracts/src/PufferModuleManager.sol 85.29% <100.00%> (+0.44%) ⬆️
mainnet-contracts/src/RestakingOperator.sol 64.86% <80.00%> (+2.36%) ⬆️

... and 2 files with indirect coverage changes


🚨 Try these New Features:

/**
* @notice Returns the owner of the RestakingOperator
*/
function operatorOwner() external view returns (address);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just use getter getOperatorOwner() in reference with setOperatorOwner()

@ksatyarth2
Copy link
Contributor

coverage is failing... the missing test could be for updateOperatorEigenDASocket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants