Unmask story #306

Veena-tw · 2020-07-07T04:36:38Z

Unmasks masked reference number to further process discovery and linking of the requests
Masks PII related information like name, mobile number, etc

ganesanarun · 2020-07-07T13:42:21Z

src/In.ProjectEKA.DefaultHip/Resources/demoPatients.json

    "careContexts": [
      {
        "referenceNumber": "NCP1112",
+        "maskedReferenceNumber": "NCPXXXX",
        "display": "National Cancer program"
      },
      {
        "referenceNumber": "NCP11122",
+        "maskedReferenceNumber": "NCPXXXXX",
        "display": "National Cancer program -  Episode 2"
      }
    ]


I would prefer to keep these masked in a different file to not pollute the patients.json.

moved the mapping to maskedReferences.json and removed from demoPatients.json

ganesanarun · 2020-07-07T13:46:50Z

src/In.ProjectEKA.HipService/Discovery/IDiscoveryRequestRepository.cs

@@ -12,5 +12,6 @@ public interface IDiscoveryRequestRepository
        Task<bool> RequestExistsFor(string requestId, string consentManagerUserId, string patientReferenceNumber);

        Task<bool> RequestExistsFor(string requestId);


Suggested change

Task<bool> RequestExistsFor(string requestId);

Task<bool> RequestExistsFor(string requestId);

ganesanarun · 2020-07-07T13:47:14Z

src/In.ProjectEKA.HipService/Discovery/Model/DiscoveryRequest.cs

@@ -20,12 +20,21 @@ public class DiscoveryRequest
        public DateTime Timestamp { get; set; }

        [Required, MaxLength(50)] public string PatientReferenceNumber { get; set; }


Suggested change

[Required, MaxLength(50)] public string PatientReferenceNumber { get; set; }

[Required, MaxLength(50)] public string PatientReferenceNumber { get; set; }

ganesanarun · 2020-07-07T13:47:42Z

src/In.ProjectEKA.HipService/Discovery/PatientDiscovery.cs

-                    new ErrorRepresentation(new Error(ErrorCode.DuplicateDiscoveryRequest, "Discovery Request already exists")));
+                    new ErrorRepresentation(new Error(ErrorCode.DuplicateDiscoveryRequest,
+                        "Discovery Request already exists")));


Is it needed?

I remember you mentioning in another PR that line should not exceed some 80 columns

120's the default column limit. I might have said 80/something whatever is default.

it is at 120.

ganesanarun · 2020-07-07T13:48:22Z

src/In.ProjectEKA.HipService/Discovery/PatientDiscovery.cs

+                        if (!careContextRepresentations.Any() &&
+                            !addToUnlinkedAccounts)


Suggested change

if (!careContextRepresentations.Any() &&

!addToUnlinkedAccounts)

if (!careContextRepresentations.Any() && !addToUnlinkedAccounts)

Modified this.

ganesanarun · 2020-07-07T13:50:12Z

src/In.ProjectEKA.HipService/Discovery/PatientDiscovery.cs

+                                    "Unable to update unlinked care contexts")));
+                        }
+
+                        patient.Identifier = patient.MaskedIdentifier;


why mutating this?

In the discovery response, masked patient identifier is sent back

Same as what I gave for zafar.

ganesanarun · 2020-07-07T13:50:13Z

src/In.ProjectEKA.HipService/Discovery/PatientDiscovery.cs

+                                    "Unable to update unlinked care contexts")));
+                        }
+
+                        patient.Identifier = patient.MaskedIdentifier;


why mutating this?

at the time of adding it into a DiscoveryRequest table these are two different fields, but at the time of returning output to CM as response we are only passing reference number and display, so we need to replace line 75 to show that on output

I understand the what you are doing, my question is why mutation?

yeah we supposed to keep CM untouched, since they are reading and returning final response from CM, and they are returning reference field not a masked even, they don't even bother about it.

ganesanarun · 2020-07-07T13:50:51Z

src/In.ProjectEKA.HipService/Discovery/PatientDiscovery.cs

+        private bool AddToUnlinkedAccounts(IEnumerable<CareContextRepresentation> careContexts,
+            string patientReferenceNumber)
+        {
+            return linkPatientRepository.SaveUnlinkedAccounts(careContexts, patientReferenceNumber).Result;
+        }


What is this?

Like the way we are storing masked patient reference number in the discovery request, we are storing the masked carecontext reference numbers of the patient in the table called UnlinkedAccounts

Why do we need this? lets get on a call.

ganesanarun · 2020-07-07T13:51:44Z

src/In.ProjectEKA.HipService/Link/LinkController.cs

+            if (e != null)
+            {
+                Log.Error(e);
+                //TODO: Handle exception - Zafar


Both are not pairing?

We are :). One name was enough to track.

…t reference for further processing - Adds a utility class to mask and unmask references

ganesanarun · 2020-07-23T09:10:09Z

src/In.ProjectEKA.HipService/Link/LinkController.cs

-    using System;
-    using System.Threading.Tasks;
-    using Discovery;
-    using Gateway;
-    using Gateway.Model;
-    using Hangfire;
-    using HipLibrary.Patient.Model;
-    using Logger;
-    using Microsoft.AspNetCore.Mvc;
-    using Microsoft.AspNetCore.Authorization;
-    using static Common.Constants;
+    using static Constants;


Its not supposed to be changed. using inside is the convention.

…t reference for further processing - Adds a utility class to mask and unmask references

into unmask_story

ganesanarun · 2020-07-23T12:55:05Z

src/In.ProjectEKA.DefaultHip/In.ProjectEKA.DefaultHip.csproj

+  <ItemGroup>
+    <Content Include="Resources\NCP1007DiagnosticReportDocument.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      <CopyToPublishDirectory>Always</CopyToPublishDirectory>
+      <Link>NCP1007DiagnosticReportDocument.json</Link>
+    </Content>
+  </ItemGroup>
+  <ItemGroup>
+    <Content Include="Resources\NCP1007PrescriptionDocument1.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      <CopyToPublishDirectory>Always</CopyToPublishDirectory>
+      <Link>NCP1007PrescriptionDocument1.json</Link>
+    </Content>
+  </ItemGroup>
+  <ItemGroup>
+    <Content Include="Resources\NCP1007PrescriptionDocument2.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      <CopyToPublishDirectory>Always</CopyToPublishDirectory>
+      <Link>NCP1007PrescriptionDocument2.json</Link>
+    </Content>
+  </ItemGroup>
+  <ItemGroup>
+    <Content Include="Resources\NCP1007PrescriptionDocument3.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      <CopyToPublishDirectory>Always</CopyToPublishDirectory>
+      <Link>NCP1007PrescriptionDocument3.json</Link>
+    </Content>
+  </ItemGroup>


Is it required?

…t reference for further processing - Adds a utility class to mask and unmask references

into unmask_story

…t reference for further processing - Adds masking of PII information

into unmask_story # Conflicts: # src/In.ProjectEKA.HipService/Link/LinkController.cs

ganesanarun · 2020-07-29T11:59:13Z

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/In.ProjectEKA.DefaultHip/Patient/MaskingUtility.cs  3
         

Clones added
============
- test/In.ProjectEKA.HipServiceTest/Discovery/PatientDiscoveryTest.cs  4
         

Clones removed
==============
+ src/In.ProjectEKA.HipService/Discovery/Database/Migrations/DiscoveryContextModelSnapshot.cs  -1

See the complete overview on Codacy

Veena-tw requested a review from a team as a code owner July 7, 2020 04:36

Veena-tw force-pushed the unmask_story branch from 98d5206 to b9f248f Compare July 7, 2020 04:55

ganesanarun reviewed Jul 7, 2020

View reviewed changes

Veena-tw force-pushed the unmask_story branch 2 times, most recently from b88a640 to ca01007 Compare July 14, 2020 04:42

Veena-tw and others added 2 commits July 16, 2020 18:20

HIP | Zafar, Veena | Unmasks patient reference number and care contex…

fe64db3

…t reference for further processing - Adds a utility class to mask and unmask references

HIP | Zafar, Veena | Adds masking of PII information

cd724f4

Veena-tw force-pushed the unmask_story branch from d39a2e2 to cd724f4 Compare July 16, 2020 12:51

ganesanarun reviewed Jul 23, 2020

View reviewed changes

Veena-tw and others added 4 commits July 23, 2020 18:14

HIP | Zafar, Veena | Unmasks patient reference number and care contex…

1aa2bfb

…t reference for further processing - Adds a utility class to mask and unmask references

HIP | Zafar, Veena | Adds masking of PII information

715b150

HIP | Zafar, Veena | Moves using statements inside the namespace

d6130ba

Merge branch 'unmask_story' of https://github.com/ProjectEKA/hip-service

5e06bb4

into unmask_story

ganesanarun reviewed Jul 23, 2020

View reviewed changes

Veena-tw and others added 8 commits July 28, 2020 11:31

HIP | Zafar, Veena | Unmasks patient reference number and care contex…

9168c81

…t reference for further processing - Adds a utility class to mask and unmask references

HIP | Zafar, Veena | Adds masking of PII information

eeb7fbe

HIP | Zafar, Veena | Moves using statements inside the namespace

2c7e3b8

HIP | Zafar, Veena | Unmasks patient reference number and care contex…

fd059d3

…t reference for further processing - Adds a utility class to mask and unmask references

HIP | Zafar, Veena | Adds masking of PII information

b80116c

Merge branch 'unmask_story' of https://github.com/ProjectEKA/hip-service

cf69d07

into unmask_story

HIP | Zafar, Veena | Unmasks patient reference number and care contex…

65388b4

…t reference for further processing - Adds masking of PII information

Merge branch 'unmask_story' of https://github.com/ProjectEKA/hip-service

5329544

into unmask_story # Conflicts: # src/In.ProjectEKA.HipService/Link/LinkController.cs

Merge branch 'master' into unmask_story

77d0ada

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unmask story #306

Unmask story #306

Veena-tw commented Jul 7, 2020 •

edited

Loading

ganesanarun Jul 7, 2020

Veena-tw Jul 9, 2020

ganesanarun Jul 7, 2020

Veena-tw Jul 9, 2020

ganesanarun Jul 7, 2020

Veena-tw Jul 9, 2020

ganesanarun Jul 7, 2020

Veena-tw Jul 8, 2020

ganesanarun Jul 9, 2020

Veena-tw Jul 9, 2020

ganesanarun Jul 7, 2020

Veena-tw Jul 8, 2020

ganesanarun Jul 7, 2020

Veena-tw Jul 9, 2020

ganesanarun Jul 9, 2020

ganesanarun Jul 7, 2020

mominzafarTW Jul 9, 2020

ganesanarun Jul 9, 2020

mominzafarTW Jul 9, 2020

ganesanarun Jul 7, 2020

Veena-tw Jul 9, 2020

ganesanarun Jul 9, 2020

ganesanarun Jul 7, 2020

Veena-tw Jul 8, 2020

ganesanarun Jul 23, 2020

ganesanarun Jul 23, 2020

ganesanarun commented Jul 29, 2020

		@@ -12,5 +12,6 @@ public interface IDiscoveryRequestRepository
		Task<bool> RequestExistsFor(string requestId, string consentManagerUserId, string patientReferenceNumber);

		Task<bool> RequestExistsFor(string requestId);

		@@ -20,12 +20,21 @@ public class DiscoveryRequest
		public DateTime Timestamp { get; set; }

		[Required, MaxLength(50)] public string PatientReferenceNumber { get; set; }

		if (!careContextRepresentations.Any() &&
		!addToUnlinkedAccounts)

Unmask story #306

Are you sure you want to change the base?

Unmask story #306

Conversation

Veena-tw commented Jul 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ganesanarun commented Jul 29, 2020

Veena-tw commented Jul 7, 2020 •

edited

Loading