Towards supporting Smarty5 (replace addDate by datepicker) #736
+39
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlutfy
commented
Dec 29, 2024
| @@ -24,29 +25,25 @@ cj(document).ready(function() { | |||
| * Utility function to set the date on the %^$W#$&$&% datepicker elements | |||
| * PRs welcome :) | |||
| **/ | |||
| function sdd_setDate(fieldname, date) { | |||
| function sdd_setDate(fieldname, date, recalculate = true) { | |||
There was a problem hiding this comment.
This recalculate param can be ignored, does not work. It was to avoid recursive issues, when sdd_setDate is called from sdd_recalculate_fields. It is not enough, because there is also an event listener for change on most of the date fields.
There was a problem hiding this comment.
Thanks a lot @mlutfy, we'll try to pick this up after the holidays.
Happy holidays and new year!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few jcalendar/smarty5 issues on the "Create new Mandate" form, but it still has a bug, which unfortunately I could not figure out.
To reproduce: enable smarty5 (by default in CiviCRM 5.80+), enable SEPA ext, and then create a new mandate. The popup will fail with a network error, and the error will be
Syntax error in template "file:CRM/common/jcalendar.tpl".This PR includes:
$form->addDateby$form->add('datepicker', ...jcalendarfrom the tpl files (it does not work on smarty5)CRM.utils.formatDate()for formatting dates$andtswithout thedomain(but didn't change everything)This PR has a bug:
sdd_recalculate_fieldsrecalculates all fields, and also updates them, which causes recursive updates if we want to trigger "change" so that things like selecting the earliest rcur start date works. I don't know enough about the logic of the code to be sure that I will not be introducing bugs.