"When nobody wants to remove the max data size limit but only increase it" #68
Conversation
| @@ -408,6 +408,12 @@ void H2CommonPatches::Init() | |||
|
|
|||
| set_tag_data_max_size(0x3000000); | |||
|
|
|||
| if (conf.getBoolean("remove_data_size_limit", true)) | |||
| { | |||
| set_tag_data_max_size(INT_MAX); | |||
There was a problem hiding this comment.
idk dude INT_MAX might be too large, maybe INT_MAX - 5
There was a problem hiding this comment.
and a setting to set make size would be best, dunno if we have a range limited setting option
There was a problem hiding this comment.
Idk if there are no issues with putting the size limit to its max there isn't really a point of putting a setting for how big you want it in (so far I haven't seen any issues when putting it to MAX)
| @@ -363,7 +363,7 @@ char __cdecl tags__fix_corrupt_fields___hook(tag_block_defintions *def, tag_bloc | |||
| return tags__fix_corrupt_fields_org(def, data, 1); | |||
| } | |||
|
|
|||
| static void set_tag_data_max_size(size_t limit) | |||
There was a problem hiding this comment.
but like seriously keep the static
There was a problem hiding this comment.
The variable won't change after putting the option if it's static?
|
#77 needs to be addressed before this can be merged. |
There was a problem hiding this comment.
Yep still an inside joke. @Berthalamew needs to stop putting it on his CV.
|
But I could just merged it 🤔 |
Fine I'll do it myself
(put "remove_data_size_limit = true" inside the H2Codez.conf to remove the max data size limit in its entirety)