Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GC every 2s rather than 0.3s #604

Merged
merged 2 commits into from
May 26, 2016
Merged

Run GC every 2s rather than 0.3s #604

merged 2 commits into from
May 26, 2016

Conversation

begriffs
Copy link
Member

Fixes #565

@begriffs
Copy link
Member Author

Looks like cabal check is confusing the RTS option with a ghc-option:

stack exec -- cabal check
The following warnings are likely affect your build negatively:
* Instead of 'ghc-options: -I2"' use 'include-dirs: 2"'

Hackage would reject this package.

Or maybe grouped quoted options is not valid in a cabal file. I'll consult the docs...

@begriffs
Copy link
Member Author

This builds and passes cabal check. Looking at its eventlog the GC doesn't run much as I use the program. Although going back to the original rtsopts the GC didn't seem to run much either.

Also if I change it to "-with-rtsopts=-N -K8" it will not crash the program whereas running with +RTS -K8 -RTS will. So I'm not sure it's actually using this configuration.

@begriffs
Copy link
Member Author

Turns out I had to run stack clean for the rtsopts to take effect in a new build. Merging.

@begriffs begriffs merged commit e76de19 into master May 26, 2016
@eric-brechemier
Copy link
Contributor

eric-brechemier commented May 26, 2016

Turns out I had to run stack clean for the rtsopts to take effect in a new build. (...)

Is it required to run stack clean for those of us building PostgREST from source?

@ruslantalpa
Copy link
Contributor

my guess is yes

On Thu, May 26, 2016 at 3:42 PM, Eric Bréchemier notifications@github.com
wrote:

Turns out I had to run stack clean for the rtsopts to take effect in a
new build. Merging.

Is it required for those of us building PostgREST from source?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#604 (comment)

@begriffs
Copy link
Member Author

To pick up changed GHC flags it's better to clean to be on the safe side.

@begriffs begriffs deleted the less-frequent-gc branch November 27, 2016 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants