Skip to content

Commit

Permalink
* Add test for rails 8.0, remove support for rails 6.x
Browse files Browse the repository at this point in the history
  • Loading branch information
PikachuEXE committed Nov 11, 2024
1 parent c5b1e5f commit 8c60a97
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 24 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
ruby:
- "3.3"
gemfile:
- gemfiles/rails_6_1.gemfile
- gemfiles/rails_7_0.gemfile
- gemfiles/rails_7_1.gemfile
- gemfiles/rails_7_2.gemfile
- gemfiles/rails_8_0.gemfile
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
COVERALLS: true
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,19 @@ jobs:
- "3.2"
- "3.3"
gemfile:
- gemfiles/rails_6_1.gemfile
- gemfiles/rails_7_0.gemfile
- gemfiles/rails_7_1.gemfile
- gemfiles/rails_7_2.gemfile
- gemfiles/rails_8_0.gemfile
allow_failures:
- false
exclude:
- ruby: "3.1"
gemfile: gemfiles/rails_8_0.gemfile
include:
- os: ubuntu
ruby: ruby-head
gemfile: gemfiles/rails_7_1.gemfile
gemfile: gemfiles/rails_8_0.gemfile
allow_failures: true
env:
BUNDLE_GEMFILE: "${{ matrix.gemfile }}"
Expand Down
17 changes: 9 additions & 8 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@

appraise "rails_6_1" do
version = "~> 6.1.0"
gem "activesupport", version
gem "actionpack", version
gem "activerecord", version
gem "railties", version
end

appraise "rails_7_0" do
version = "~> 7.0.0"
gem "activesupport", version
Expand All @@ -30,3 +22,12 @@ appraise "rails_7_2" do
gem "activerecord", version
gem "railties", version
end

appraise "rails_8_0" do
version = "~> 8.0.0"
gem "activesupport", version
gem "actionpack", version
gem "activerecord", version
gem "railties", version
end

6 changes: 3 additions & 3 deletions action_controller_tweaks.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ Gem::Specification.new do |s|
s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
s.require_paths = ["lib"]

s.add_dependency "activesupport", ">= 6.0.0", "< 8.0.0"
s.add_dependency "actionpack", ">= 6.0.0", "< 8.0.0"
s.add_dependency "activesupport", ">= 7.0.0", "< 8.1.0"
s.add_dependency "actionpack", ">= 7.0.0", "< 8.1.0"

s.add_development_dependency "bundler", ">= 1.0.0"
s.add_development_dependency "rake", ">= 10.0", "<= 14.0"
s.add_development_dependency "appraisal", "~> 2.0", ">= 2.5.0"
s.add_development_dependency "rspec-rails", ">= 5.1", "< 8"
s.add_development_dependency "rspec-its", "~> 1.0"
s.add_development_dependency "rspec-its", "~> 2.0"
# rspec-rails needs activerecord...
s.add_development_dependency "activerecord", ">= 4.0.0"
s.add_development_dependency "sqlite3", ">= 1.3"
Expand Down
10 changes: 0 additions & 10 deletions gemfiles/rails_6_1.gemfile

This file was deleted.

10 changes: 10 additions & 0 deletions gemfiles/rails_8_0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "activesupport", "~> 8.0.0"
gem "actionpack", "~> 8.0.0"
gem "activerecord", "~> 8.0.0"
gem "railties", "~> 8.0.0"

gemspec path: "../"

0 comments on commit 8c60a97

Please sign in to comment.