Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow emitting SubscribeEvent in Patcher #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow emitting SubscribeEvent in Patcher #5

wants to merge 1 commit into from

Conversation

TheGlitch76
Copy link
Member

@TheGlitch76 TheGlitch76 commented May 25, 2020 •
edited
Loading

I want to preserve forge's magic annotations so that the decompiled bytecode is easier to follow.

@TheGlitch76 TheGlitch76 requested a review from coderbot16 May 25, 2020 02:36
@coderbot16
Copy link
Member

I'm not a huge fan of bringing these annotations back, if possible it would be nice to have them in a separate compilation unit that's not included by default.

coderbot16
coderbot16 requested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@coderbot16 coderbot16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are bringing back @SubscribeEvent, it would make sense to include all of the parameters/arguments too (priority, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderbot16 coderbot16 coderbot16 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheGlitch76 @coderbot16