Skip to content

Commit

Permalink
Remove a deliberately non-deterministic test
Browse files Browse the repository at this point in the history
This test would pass if execution either succeeded or failed with a
EependencyError. It did not assert any relationship between those
two possibilities and whether earlier tasks actually succeeded or
failed.

test_fail_sequence in the same file tests more strongly whether a
failure is correctly propagated.
  • Loading branch information
benclifford committed Jan 11, 2025
1 parent 5aac648 commit fe60352
Showing 1 changed file with 0 additions and 25 deletions.
25 changes: 0 additions & 25 deletions parsl/tests/test_python_apps/test_fail.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,28 +41,3 @@ def test_fail_sequence(fail_probs):

with pytest.raises(DependencyError):
t_final.result()


def test_deps(width=3):
"""Random failures in branches of Map -> Map -> reduce"""
# App1 App2 ... AppN
futs = [random_fail(fail_prob=0.4) for _ in range(width)]

# App1 App2 ... AppN
# | | |
# V V V
# App1 App2 ... AppN

futs = [random_fail(fail_prob=0.8, inputs=[f]) for f in futs]

# App1 App2 ... AppN
# | | |
# V V V
# App1 App2 ... AppN
# \ | /
# \ | /
# App_Final
try:
random_fail(fail_prob=0, inputs=futs).result()
except DependencyError:
pass

0 comments on commit fe60352

Please sign in to comment.