feat: ipsec_tunnel_status check Proxy ID support #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ipsec_tunnel_status` check to accept a list of `proxy_ids` to check tunnel status against the provided list, checks for all configured Proxy IDs if not provided. Returns success if any Proxy ID is in active state for the ipsec tunnel or `require_all_active` flag can be set to require all Proxy IDs to be in active state.
alperenkose
requested review from
adambaumeister and
horiagunica
as code owners
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
A Preview PR in PanDev repo has been created. You can view it here. |
horiagunica
approved these changes
Oct 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
## [1.1.0](v1.0.1...v1.1.0) (2024-10-30) ### Features * ipsec_tunnel_status check Proxy ID support ([#174](#174)) ([7ae2bd5](7ae2bd5))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on PyPI and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Proxy IDs to
ipsec_tunnel_statusreadiness check.ipsec_tunnel_statuscheck now accepts a list ofproxy_idsto check tunnel status against the provided list, or it checks for all configured Proxy IDs if not provided.By default it will return success if any Proxy ID is in active state for the ipsec tunnel or
require_all_activeflag can be set to require all Proxy IDs to be in active state.Motivation and Context
ipsec_tunnel_statusreadiness check didn't work if IPSec tunnel was configured with Proxy IDs.With this enhancement it checks for all the proxy ids for the given tunnel name and returns success if any is in active state. It is also possible to provide a list of proxy ids to limit the check on specific Proxy IDs.
How Has This Been Tested?
Tested with the written unittests.
Types of changes
Checklist