fix(firewall_proxy/is_panorama_connected): Added fix for panorama check for FWs in version PAN-OS 11 or later

[horiagunica]

Description

This PR closes #158 .

FWs in PAN-s 11.0 and later removed a line from the show panorama-status op command output:

Pre-version 11.0:

<Panorama Server 1 : 10.10.10.5
    Connected     : yes
    HA state      : Active

Panorama Server 2 : 10.10.10.6
    Connected     : yes
    HA state      : Passive>.

Version >=11.0:

<Panorama Server 1 : 10.10.10.5
    Connected     : yes
    HA state      : Active
Panorama Server 2 : 10.10.10.6
    Connected     : yes
    HA state      : Passive>.

This resulted in two different list lengths that did no match the condition properly.

Motivation and Context

Support for PAN-OS >=11.0 for is_panorama_connected check .

How Has This Been Tested?

Local Example with two different versions:

python3 run_readiness_checks.py -d <pan_os_v11> -u admin -p <MY_PASS>
['Panorama Server 1 : 10.10.10.5', '    Connected     : yes', '    HA state      : Active', 'Panorama Server 2 : 10.10.10.6', '    Connected     : yes', '    HA state      : Passive']
 panorama:
   | state: True
   | reason: [SUCCESS]
True [SUCCESS]

python3 run_readiness_checks.py -d <pan_os_v10.2> -u admin -p <MYP_PASS>
['Panorama Server 1 : 10.10.10.5', '    Connected     : yes', '    HA state      : Active', '', 'Panorama Server 2 : 10.10.10.6', '    Connected     : yes', '    HA state      : Passive']
 panorama:
   | state: True
   | reason: [SUCCESS]
False [FAIL] Peer device is not in active or passive state.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes if appropriate.
• All new and existing tests passed.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
panos_upgrade_assurance
firewall_proxy.py
Project Total

This report was generated by python-coverage-comment-action

[github-actions]

A Preview PR in PanDev repo has been created. You can view it here.

[adambaumeister]

Is there a reason we're not just doing a simple re.search('connected: yes') here?

[horiagunica]

I see no reason not to :) - refactored the code - please have a look.

[alperenkose]

LGTM 👍🏻

[adambaumeister]

The only comment I have here is that this will fail if there are two panorama's present and one isn't connected but the other is. This is probably the behavior we want anyway :)

[horiagunica]

🎉 This PR is included in version 0.3.4 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot