-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added talawa mobile offline first features documentation #863
Added talawa mobile offline first features documentation #863
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests and there are no merge conflicts. The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
I would also like to mention this figma link as part of documentation how can I do it. |
@aashimawadhwa has access to our official Figma documents and will be able to access to update them. The links can be found here: |
@@ -25,7 +25,8 @@ | |||
"prettier": "^3.3.3", | |||
"prism-react-renderer": "^2.4.0", | |||
"react": "^18.2.0", | |||
"react-dom": "^18.2.0" | |||
"react-dom": "^18.2.0", | |||
"yarn": "^1.22.22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palisadoes I have run npm yarn install
in development so this file has been changed please have a look. Resulting in an edit of unauthorised file.
e1cb806
into
PalisadoesFoundation:develop
@Azad99-9 as this is a figma jam file we can create a separate reference to it from the talwa main website. keeping it in the figma is not a great idea @palisadoes |
@aashimawadhwaa Should we revert this? |
@aashimawadhwaa could you please tell me how exactly should I proceed? |
What kind of change does this PR introduce?
Issue Number:
Fixes 2548 of talawa mobile
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?