Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added talawa mobile offline first features documentation #863

Merged

Conversation

Azad99-9
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Fixes 2548 of talawa mobile

Did you add tests for your changes?

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests and there are no merge conflicts.

The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@Azad99-9
Copy link
Contributor Author

@palisadoes

I would also like to mention this figma link as part of documentation how can I do it.

@Azad99-9 Azad99-9 changed the title Addd talawa mobile offline first features documentation Added talawa mobile offline first features documentation Sep 10, 2024
@palisadoes
Copy link
Contributor

@palisadoes

I would also like to mention this figma link as part of documentation how can I do it.

@aashimawadhwa has access to our official Figma documents and will be able to access to update them.

The links can be found here:

@@ -25,7 +25,8 @@
"prettier": "^3.3.3",
"prism-react-renderer": "^2.4.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react-dom": "^18.2.0",
"yarn": "^1.22.22"
Copy link
Contributor Author

@Azad99-9 Azad99-9 Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palisadoes I have run npm yarn install in development so this file has been changed please have a look. Resulting in an edit of unauthorised file.

@palisadoes palisadoes merged commit e1cb806 into PalisadoesFoundation:develop Sep 15, 2024
3 of 4 checks passed
@aashimawadhwaa
Copy link

@Azad99-9 as this is a figma jam file we can create a separate reference to it from the talwa main website. keeping it in the figma is not a great idea @palisadoes

@palisadoes
Copy link
Contributor

@aashimawadhwaa Should we revert this?

@Azad99-9
Copy link
Contributor Author

@aashimawadhwaa could you please tell me how exactly should I proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document all the Offline First Features developed so far as part of GSoC.
3 participants