Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workflow for pulling docs from api repo #774

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

adi790uu
Copy link
Contributor

What kind of change does this PR introduce?

feature

Issue Number:

This PR is for the issue in api repo : PalisadoesFoundation/talawa-api#1897

Did you add tests for your changes?

No

Snapshots/Videos:

If relevant, did you update the documentation?

No

Summary

This PR introduces a workflow which updated the talwa-api-repo folder to the latest changes.

Does this PR introduce a breaking change?

Yes

Have you read the contributing guide?

Yes

@adi790uu adi790uu requested a review from palisadoes as a code owner March 19, 2024 11:03
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests and there are no merge conflicts.

The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@adi790uu
Copy link
Contributor Author

@anwersayeed I don't know why the previous PR got closed but I have implemented the review comments.

@adi790uu
Copy link
Contributor Author

adi790uu commented Mar 19, 2024

@palisadoes we need to decide the schedule of cron job do give your opinion on this.

@palisadoes palisadoes removed their request for review March 19, 2024 21:21
@palisadoes
Copy link
Contributor

@palisadoes we need to decide the schedule of cron job do give your opinion on this.

Please work with @anwersayeed and @tasneemkoushar on this and other questions. I trust their judgement.

@anwersayeed
Copy link
Contributor

@adi790uu Set it to run weekly, every Sunday.

@adi790uu
Copy link
Contributor Author

@anwersayeed changed it to sunday midnight

@anwersayeed
Copy link
Contributor

anwersayeed commented Mar 21, 2024

@palisadoes This PR is ready to be merged, once merged, we need to look for how it behaves on our repositories.

@anwersayeed
Copy link
Contributor

@adi790uu Please work on replicating this for talawa-admin and talawa documentation as well.

@palisadoes palisadoes merged commit 4c11bcb into PalisadoesFoundation:develop Mar 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants