Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation workflow #968

Closed
wants to merge 0 commits into from
Closed

Update documentation workflow #968

wants to merge 0 commits into from

Conversation

Nitya-Pasrija
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes
Copy link
Contributor

@anwersayeed @tasneemkoushar Please review

@github-actions
Copy link

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Sep 17, 2023
@palisadoes
Copy link
Contributor

@anwersayeed @tasneemkoushar Should we close this?

@github-actions github-actions bot removed the no-pr-activity No pull request activity label Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Oct 1, 2023
@palisadoes
Copy link
Contributor

@anwersayeed @tasneemkoushar Should this be closed or should it be merged?

@github-actions github-actions bot removed the no-pr-activity No pull request activity label Oct 14, 2023
@github-actions
Copy link

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Oct 24, 2023
@noman2002
Copy link
Member

@anwersayeed @tasneemkoushar Should this be closed ??

@github-actions github-actions bot removed the no-pr-activity No pull request activity label Nov 13, 2023
@Nitya-Pasrija
Copy link
Contributor Author

This one changes the token name but as the Talawa Admin docs were failing previously, maybe this was the PR that we missed merging.

@palisadoes
Copy link
Contributor

@Nitya-Pasrija Can you fix the failing tests for this so that we can get it workflow operational? It does not look like a lot of work.

@anwersayeed
Copy link
Contributor

@Nitya-Pasrija Can you fix the failing tests for this so that we can get it workflow operational? It does not look like a lot of work.

We may close this for now.

@palisadoes
Copy link
Contributor

@anwersayeed There is no issue for this PR

Please create an issue for this so that we can track it, then close this PR.

@Nitya-Pasrija
Copy link
Contributor Author

@Nitya-Pasrija Can you fix the failing tests for this so that we can get it workflow operational? It does not look like a lot of work.

Sure, I'm looking into this one

@palisadoes
Copy link
Contributor

@Nitya-Pasrija This is causing the Talawa-Admin documentation to be missing from docs.talawa.io. How is your progress?

@palisadoes
Copy link
Contributor

@Nitya-Pasrija This is causing the Talawa-Admin documentation to be missing from docs.talawa.io.

  1. How is your progress?
  2. When do you estimate that you'll be able to complete this?

@tasneemkoushar
Copy link
Contributor

@Nitya-Pasrija any progress on this PR?

@Nitya-Pasrija
Copy link
Contributor Author

I have started looking into it, will resolve it max to max by first week of December

@palisadoes
Copy link
Contributor

I have started looking into it, will resolve it max to max by first week of December

@Nitya-Pasrija Are you still on track to complete this by next week?

@palisadoes
Copy link
Contributor

@Nitya-Pasrija Are you still on track to complete this?

@Nitya-Pasrija
Copy link
Contributor Author

Yep. I'll be creating a PR by Sunday evening

@SiddheshKukade SiddheshKukade added the documentation Improvements or additions to documentation label Dec 9, 2023
@palisadoes
Copy link
Contributor

@Nitya-Pasrija Why was this closed?

@Nitya-Pasrija
Copy link
Contributor Author

A recent PR 968 on Talawa docs, has created major changes and resolves the linking errors as well. Thus, it would have created confusion to have two different PRs referencing different workflows

@palisadoes
Copy link
Contributor

@Nitya-Pasrija there is no PR 968.

What is the PR you are referencing?

@Nitya-Pasrija
Copy link
Contributor Author

There is ons under the talawa-docs repository, cuz of the version updates the workflows were activated and hence, they are all working out now.

@palisadoes
Copy link
Contributor

Do you mean this PR? And if so, is everything working in the documentation workflow for Talawa Admin and Talawa API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palisadoes palisadoes Awaiting requested review from palisadoes

@anwersayeed anwersayeed Awaiting requested review from anwersayeed

@tasneemkoushar tasneemkoushar Awaiting requested review from tasneemkoushar

Assignees

@Nitya-Pasrija Nitya-Pasrija

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nitya-Pasrija @palisadoes @noman2002 @anwersayeed @tasneemkoushar @SiddheshKukade