solución Docker Firebase #980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoantoniak
requested review from
fivanparedes,
jorferr89 and
matiasagbenitez
and removed request for
a team
SuichiM
reviewed
Dec 8, 2022
| @@ -1,12 +1,23 @@ | |||
| FROM php:7.2-apache | |||
| FROM ubuntu:latest | |||
There was a problem hiding this comment.
seria bueno utilizar uno de node directamente se podria definir una version especifica, y en base a eso hacer el npm install
no es muy estandar bajarse los binarios de las dependencias que uno necesita, pero ello ya cada tecnologia maneja su gestor de paquetes.
composer, npm, bundler etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se modifica el tipo de contenedor desde PHP a Ubuntu y se instala Firebase Tools con un binario directamente en /bin/ para no necesitar agregar la ruta al PATH.