Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually lock mn collateral #513

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jan 3, 2025

Abstract

Automatically lock and unlock mn collateral (This PR was tested by lowering the required collateral to 0.1 PIV in my test wallet)
image

Testing

  • Test that you can't spend the mn collateral unless you delete it

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit ce0cccd
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6777dce2f6e2360008f8354d
😎 Deploy Preview https://deploy-preview-513--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino Duddino self-assigned this Jan 3, 2025
@Duddino Duddino added the Bug This is either a bugfix (PR) or a bug (issue). label Jan 3, 2025
@Duddino Duddino mentioned this pull request Jan 8, 2025
4 tasks
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK ce0cccd

Tested using the suggested method - changing chainparam collateralInSats to 0.1 PIV, locking, refreshing the app and performing a bunch of transactions. Collateral remained locked.

@Duddino Duddino merged commit 3bd89b8 into PIVX-Labs:master Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants