Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS: Default to OpenGL for RDNA 2 and 3 on windows. #12144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lightningterror
Copy link
Contributor

@lightningterror lightningterror commented Dec 31, 2024

Description of Changes

When someone buys an RDNA 3 GPU please debug the driver timeouts on windows to figure out what's causing the crashes on Vulkan, seems to be related to barriers.

RDNA 2 and higher support feature level 12.2 so use that to detect RDNA 3.

Rationale behind Changes

Avoid driver timeouts on RDNA3 on Vulkan.
We need someone with an RDNA3 GPU to debug and fix the issue which we don't have.

Suggested Testing Steps

Test to make sure rdna 2 and 3 default to gl, older vulkan capable to vulkan, legacy to dx11.

When someone buys an RDNA 3 GPU please debug the driver timeouts on windows to figure out what's  causing the crashing, seems to be related to barriers.

RDNA 2 and higher support feature level 12.2 so use that to detect RDNA 3.
@TellowKrinkle
Copy link
Member

Why are we including RDNA2 in this?

@RinMaru
Copy link

RinMaru commented Jan 1, 2025

Why are we including RDNA2 in this?

Exactly what im thinking. I haven't had any issues on my 6700XT RDNA2 and I use VK exclusively
Windows 11 24H2
Adrenalin 24.12.1

@lightningterror
Copy link
Contributor Author

Because otherwise we'd have to hardcode every rdna3 and possibly future gpu to default to GL instead and I don't like that, you can still switch from Auto to Vulkan for rdna2.

@mirh
Copy link

mirh commented Jan 1, 2025

Couldn't you use some other architectural feature?
Feature level alone has the little problem that it would probably always be 12_1 on W10.

@JordanTheToaster
Copy link
Member

Couldn't you use some other architectural feature? Feature level alone has the little problem that it would probably always be 12_1 on W10.

Both RDNA 2 and 3 are identical feature level wise you cannot use that to pick one or the other.

@AmyRoxwell
Copy link

Probably would be a good idea to make an issue page about this, just in the case an external dev with a RDNA3 GPU sees it and might be able to debug it or just for the sake to keep track on the issue.

@mirh
Copy link

mirh commented Jan 1, 2025

Both RDNA 2 and 3 are identical feature level wise you cannot use that to pick one or the other.

In my link, shader model 6.8 is specifically singled out.
Not sure if even that could be queried from inside W10, but it seems impossible that over hundreds of caps they would all be the same.

Speaking of which, I guess resource binding could also be used to distinguish between fermi, kepler and maxwell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants