EE: Allow mapping main memory anywhere #11734
Open
+413
−579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used for holding a pointer to the PCSX2 text section
TellowKrinkle
force-pushed
the
FullRelocation
branch
4 times, most recently
from
882fabf to
ffccfdc
Compare
TellowKrinkle
force-pushed
the
FullRelocation
branch
from
ffccfdc to
87b795e
Compare
F0bes
reviewed
Aug 26, 2024
There was a problem hiding this comment.
When testing on Linux this appears to break software mode for multiple games. It usually looks something like this:
(remove the .zip from the end)
Colin McRae Rally 3_SLUS-20502_20240826111944.gs.zst.zip
TellowKrinkle
force-pushed
the
FullRelocation
branch
from
87b795e to
9229be9
Compare
|
SW renderer should be fixed |
TellowKrinkle
force-pushed
the
FullRelocation
branch
2 times, most recently
from
675a9ba to
899b4b5
Compare
We don't need MAP_FIXED anymore
They need to stay near each other for the x86 JIT to work
Allows more code to access members with 8b offsets
Allows more instructions to use 1-byte offsets
TellowKrinkle
force-pushed
the
FullRelocation
branch
from
899b4b5 to
eb0b341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #11728
Uses rbx as a pointer to the main PCSX2 text section, allowing recompiler memory to be placed anywhere
Rationale behind Changes
Prevent the emulator from failing to start when it can't find anywhere to map recompiler memory
Suggested Testing Steps
Test recompilers with all the settings you can think of, it's very possible I broke something
(Also I haven't tested Windows or Linux at all, I expect Linux to work since its implementation is mostly shared with macOS but Windows who knows)