-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: finalize button v1 #246
Open
florentmaitre
wants to merge
13
commits into
develop
Choose a base branch
from
243-component-button---finalize-v1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟢 Netlify deploy for commit 559d647 succeededDeploy preview: https://677e62e5c1945e0c514299e9--ouds-android.netlify.app |
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 30, 2024 15:24
bc76311
to
e955ef0
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
2 times, most recently
from
December 30, 2024 15:25
4ab6e8c
to
f9f6eda
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 30, 2024 16:00
f9f6eda
to
31d71d2
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 30, 2024 18:02
31d71d2
to
0023694
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 30, 2024 18:04
0023694
to
1aada80
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 30, 2024 18:14
1aada80
to
e767626
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 30, 2024 18:16
e767626
to
5ecd054
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 30, 2024 18:18
5ecd054
to
26412be
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 31, 2024 14:31
26412be
to
f24ea23
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 31, 2024 16:16
f24ea23
to
61cbf0e
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
December 31, 2024 17:22
61cbf0e
to
97e7051
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
January 2, 2025 17:20
9bb8ebe
to
678b03a
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
January 3, 2025 09:43
678b03a
to
112f5e0
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
January 3, 2025 15:40
cd1ac1d
to
7e1d7ef
Compare
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
January 3, 2025 16:03
7e1d7ef
to
2bccad6
Compare
paulinea
requested changes
Jan 6, 2025
core/src/main/java/com/orange/ouds/core/component/button/OudsButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/orange/ouds/app/ui/components/button/ButtonDemoScreen.kt
Show resolved
Hide resolved
core/src/main/java/com/orange/ouds/core/component/samples/OudsButtonSamples.kt
Show resolved
Hide resolved
florentmaitre
force-pushed
the
243-component-button---finalize-v1
branch
from
January 7, 2025 10:51
c594350
to
de03ddb
Compare
@paulinea & @florentmaitre I've Just got the following feedback from Maxime: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.