Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: finalize button v1 #246

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

florentmaitre
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 30, 2024

@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from bc76311 to e955ef0 Compare December 30, 2024 15:24
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch 2 times, most recently from 4ab6e8c to f9f6eda Compare December 30, 2024 15:25
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from f9f6eda to 31d71d2 Compare December 30, 2024 16:00
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 31d71d2 to 0023694 Compare December 30, 2024 18:02
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 0023694 to 1aada80 Compare December 30, 2024 18:04
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 1aada80 to e767626 Compare December 30, 2024 18:14
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from e767626 to 5ecd054 Compare December 30, 2024 18:16
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 5ecd054 to 26412be Compare December 30, 2024 18:18
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 26412be to f24ea23 Compare December 31, 2024 14:31
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from f24ea23 to 61cbf0e Compare December 31, 2024 16:16
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 61cbf0e to 97e7051 Compare December 31, 2024 17:22
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 9bb8ebe to 678b03a Compare January 2, 2025 17:20
@florentmaitre florentmaitre force-pushed the 243-component-button---finalize-v1 branch from 678b03a to 112f5e0 Compare January 3, 2025 09:43
Copy link

github-actions bot commented Jan 7, 2025

📱 Alpha release available

Scan the QR code below to download and install the Design System Toolbox app which contains the changes of this pull request.
Please note that the link behind this QR code will expire in one hour.
qrcode

@B3nz01d
Copy link
Collaborator

B3nz01d commented Jan 7, 2025

the card to acces the button is not using the latest design elements
Screenshot 2025-01-07 at 15 39 37

@Franco-Riccitelli
Copy link
Member

Design review comments for Android buttons in the Orange theme in light and dark modes.

I noticed two issues.
The height, padding and icon size are different from the button designs in the Figma files.
The example shows the button design from the Figma file (left) and a screen capture of the Android version (right).
Button sizes
The other issue was the orange colour (for state changes) and the red colours (for the negative button). These differences could have been due to the Android device I was using and how it rendered the colours. The example shows the orange colour used on the Android button (right), which are slightly darker than the version in the button Figma file (left).
Button colours
The example for the negative button shows the Android button (right), which are slightly darker than the version in the button Figma file (left).
Negative buttons

@B3nz01d
Copy link
Collaborator

B3nz01d commented Jan 9, 2025

@paulinea & @florentmaitre I've Just got the following feedback from Maxime:
When the selected style is set to "loading" the loader animation is not centered in the button
Screenshot_20250109-123240.png

Copy link

📱 Alpha release available

Scan the QR code below to download and install the Design System Toolbox app which contains the changes of this pull request.
Please note that the link behind this QR code will expire in one hour.
qrcode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Button - Finalize V1
4 participants