Fix need for tiocsti workaround #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug Orange-Cyberdefense#77 Use a subprocess to provide the same behaviour. Fix the termios calls when the keyboard is proccess to exit a run part way through (existing issue).
|
Hello thank you for the pull request ! However we cannot validate your commits because it will cause many issues. For instance a user will not be able to change the command he choose, moreover as the new command is run by subprocess, alias will not be interpreted. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #77
Use a subprocess to provide the same behaviour.
Fix the termios calls when the keyboard is proccess to exit a run part way through (existing issue).