ci-tests #9
Closed
ci-tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good! Seems like it is working. I'll re-run the test once |
4meta5
reviewed
Nov 15, 2023
Comment on lines
+50
to
+70
| - name: cargo fmt | ||
| uses: actions-rs/cargo@ae10961054e4aa8b4aa7dffede299aaf087aa33b # @v1.0.1 | ||
| with: | ||
| command: fmt | ||
| args: --all -- --check | ||
|
|
||
| - name: cargo test --locked | ||
| uses: actions-rs/cargo@ae10961054e4aa8b4aa7dffede299aaf087aa33b # @v1.0.1 | ||
| with: | ||
| command: test | ||
|
|
||
| - name: cargo clippy --locked | ||
| uses: actions-rs/clippy-check@b5b5f21f4797c02da247df37026fcd0a5024aa4d # @v1.0.7 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| args: --locked --all-targets -- -D warnings |
There was a problem hiding this comment.
where is cargo check/build --release?
Also eventually we will want to also test compilation with other feature flags i.e. --features = runtime-benchmarks, but that can be added later.
There was a problem hiding this comment.
cargo test compiles code in std so it is not sufficient to test release compilation
There was a problem hiding this comment.
where is cargo check/build --release?
- for cargo check: clippy itself runs cargo check afaik: https://github.com/rust-lang/rust-clippy/blob/c154754b74577906c5d55d57f7daeff02d6a33e7/src/main.rs#L59
- for cargo build: I thought we will have a separate workflow for releases
4meta5
previously approved these changes
Nov 22, 2023
add components to toolchain cargo fmt adding components specifically
ozgunozerk
force-pushed
the
cargo-workflow
branch
from
bbbc515 to
4820a92
Compare
|
I closed the PR, since I couldn't find a reliable way to progress on the issue. Might test on my own, did not want to spam you further with notifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is providing a template for running the most important cargo commands in our CI-test.
We can use this CI as a condition in our PRs, so even if we forget to run
cargo clippyfor example, github won't :)I've configured it, so that it will only run the test in ubuntu machines, but not on windows and macos. I thought running on all 3 major OS for each run would be an overkill.
If we want to run the test on macos and windows, I've added a dispatch option, we can manually dispatch this test on macos and windows.