Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pallet grouping macros #300

Merged
merged 66 commits into from
Nov 4, 2024
Merged

Pallet grouping macros #300

merged 66 commits into from
Nov 4, 2024

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Aug 26, 2024 •
edited
Loading

Ready for Review!

Closes #257

  • configure macros in generic-template: system, consensus, assets, governance, xcm
  • configure macros in evm-template: system, consensus, assets, governance, xcm, evm
  • single file config for OpenZeppelinRuntime (per runtime)
  • minimal type aliasing + maximal direct assignment in the single file config
  • merge xtokens into both templates: xtokens config #331 , xtokens on generic #343
  • merge xcm-transactor into both templates: xcm-transactor on evm #345 , merge xcm-transactor on generic #346
  • update macros to include xtokens, xcm-transactor
  • resolve merge conflicts => merge into main with macro changes
  • merge macros
  • wrappers release
  • update macro dep to point to release tag

@netlify Netlify

This comment has been minimized.

Sign in to view
@4meta5 4meta5 mentioned this pull request Aug 26, 2024
Merged
18 tasks
@4meta5 4meta5 self-assigned this Aug 27, 2024
@4meta5 4meta5 added enhancement New feature or request priority: 3 We will resolve this first before everything else. labels Aug 27, 2024
4meta5 added 20 commits August 27, 2024 12:30
@4meta5
clean
03b1269
@4meta5
timestamp
986b60f
@4meta5
parachain info
508d7db
@4meta5
preimage and scheduler
dc70159
@4meta5
proxy and balances
2e5ddbc
@4meta5
utility and parachain system
237d55e
@4meta5
use construct openzeppelin runtime
1b86792
@4meta5
generic runtime apis
187e95c
@4meta5
pause construct runtime until other macros validated by cross templat…
75eda33 
…e usage
@4meta5
hold runtime construction until inner macros validated
9c0add3
@4meta5
evm template impl openzeppelin system
97b3b72
@4meta5
revert back to generic construct runtime minimal wrapper for now
f7789d8
@4meta5
use the trivial versions for the construct runtime and impl runtime a…
866992b 
…pi macros for now
@4meta5
fix system grouping macro name
ae368b5
@4meta5
consensus wrapper in generic template
303c782
@4meta5
include ExistentialDeposit as explicit system parameter and add asset…
ced0699 
… grouping for generic
@4meta5
wip governance
4d1a5cf
@4meta5
wip governnace for generic
8a7cb35
@4meta5
rm placeholders for runtime api and construct runtime until implemented
c5c30e4
@4meta5
fix evm template after latest changes to system grouping
6920ef4
@4meta5 4meta5 mentioned this pull request Oct 28, 2024
Closed
3 tasks
ggonzalez94
ggonzalez94 reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just did a first pass and will continue tomorrow

generic-template/runtime/src/configs/mod.rs Outdated Show resolved Hide resolved
generic-template/runtime/rustc-ice-2024-10-27T01_16_36-90798.txt Outdated Show resolved Hide resolved
generic-template/Cargo.toml Outdated Show resolved Hide resolved
ggonzalez94
ggonzalez94 reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished a second pass, left a few extra comments and questions. I still have a few that I think would be easier to discuss during our sync tomorrow.
But this is coming together nicely, and I think we should be able to merge it in the next 1-2 days

evm-template/runtime/src/configs/mod.rs Outdated Show resolved Hide resolved
generic-template/runtime/src/configs/mod.rs Outdated Show resolved Hide resolved
evm-template/runtime/src/configs/xcm_config.rs Outdated Show resolved Hide resolved
evm-template/runtime/src/configs/mod.rs Outdated Show resolved Hide resolved
generic-template/runtime/src/configs/asset_config.rs Outdated Show resolved Hide resolved
@4meta5

This comment has been minimized.

Sign in to view
@KitHat KitHat mentioned this pull request Nov 1, 2024
Merged
2 tasks
@4meta5
Copy link
Contributor Author

4meta5 commented Nov 3, 2024

Both nodes are compiling. Will update the direct path dependency to point to the release once OpenZeppelin/openzeppelin-pallet-abstractions#1 is merged and it is released.

ggonzalez94
ggonzalez94 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We just need to update the Cargo.toml once we release the wrappers.

@ggonzalez94
Copy link
Collaborator

Merging this so we can merge #354, which is built on top of this and create the rc.
@4meta5 if there were any pending changes(I think there weren't) please add them on a new PR 🙏

@ggonzalez94 ggonzalez94 merged commit 8e0feec into main Nov 4, 2024
5 of 6 checks passed
@ggonzalez94 ggonzalez94 deleted the amar-system-wrapper-poc2 branch November 4, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgunozerk ozgunozerk ozgunozerk approved these changes

@ggonzalez94 ggonzalez94 ggonzalez94 approved these changes

@KitHat KitHat KitHat approved these changes

Assignees

@4meta5 4meta5

Labels
enhancement New feature or request priority: 3 We will resolve this first before everything else.
Projects
Substrate Runtime Templates
Status: ✅ Done
Milestone
Deliverable 3 - Developer experience,...
Development

Successfully merging this pull request may close these issues.

🎁 [Feature Request]: Pallet Abstractions to Improve DX
4 participants
@4meta5 @ggonzalez94 @KitHat @ozgunozerk