Skip to content

Commit

Permalink
Merge branch 'main' into ozgun-upgrade-polkadot-sdk-v1.13.0
Browse files Browse the repository at this point in the history
  • Loading branch information
ozgunozerk authored Sep 13, 2024
2 parents 069d718 + a4b7acf commit ab8e657
Show file tree
Hide file tree
Showing 13 changed files with 27 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 🐞 Bug report
description: Create a report to help us improve
title: "🐞 [Bug]: "
labels: ["bug"]
labels: ["bug", "needs triage"]
body:
- type: markdown
attributes:
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/core_implementation.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 🏗️ Core Implementation
description: Create a report to help us improve
title: "🏗️ [Core Feature]: "
labels: ["core"]
labels: ["core", "needs triage"]
body:
- type: checkboxes
id: templates
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: 🎁 Feature Request
description: Suggest an idea for this project ⚡️
title: "🎁 [Feature Request]: "
labels: ["enhancement"]
labels: ["enhancement", "needs triage"]
body:
- type: markdown
attributes:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/generic-weekly-fuzzer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ jobs:

- name: Add dependencies
run: cargo install ziggy cargo-afl honggfuzz grcov

- name: Build AFL config
run: cargo afl config --build

- name: Add target
run: rustup target add wasm32-unknown-unknown
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/typos.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Check for typos

on: [pull_request]

jobs:
check-for-typos:
runs-on: ubuntu-latest
steps:
- name: Checkout the repository
uses: actions/checkout@v4

- name: Check for typos
uses: crate-ci/typos@v1.24.5
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/guides/predeployed_contracts.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ If you do not want any contract to be predeployed, you can use the `--no-predepl

== Limitations

* Contructors are not executed at the moment. So if your contract needs any initialization, consider deploying it as usual.
* Constructors are not executed at the moment. So if your contract needs any initialization, consider deploying it as usual.
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/pallets/multisig.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ The result is equivalent to the dispatched result if the threshold is exactly

TIP: If this is the final approval, you will want to use `as_multi` instead. `approve_as_multi` won’t trigger the dispatch, even if there are enough approvals.

The reason is: `as_multi` needs `call` parameter, whereas `approve_as_mutli` needs `call_hash`. `call_hash` is enough to find the multisig operation entry in the storage, and increment the vote count. We don’t need the `call` itself to increment the vote count. Whereas, if `call` is supplied, and if we have enough approvals, the logic for execution will be triggered. This is a design choice.
The reason is: `as_multi` needs `call` parameter, whereas `approve_as_multi` needs `call_hash`. `call_hash` is enough to find the multisig operation entry in the storage, and increment the vote count. We don’t need the `call` itself to increment the vote count. Whereas, if `call` is supplied, and if we have enough approvals, the logic for execution will be triggered. This is a design choice.

**Params:**

Expand Down
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/pallets/parachain-system.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ This pallet is a core element of each parachain. It will:
** `DmpQueue` — a handler for the incoming *downward* messages from relay chain
** `ReservedDmpWeight` — xref:glossary.adoc#weight[weight] reserved for DMP message processing. This config seems to be is not used as the function that processes these messages (`enqueue_inbound_downward_messages`) returns used weight.
** `XcmpMessageHandler` — a handler for the incoming _horizontal_ messages from other parachains
** `ReservedXcmpWeight` — default weight limit for the for the XCMP message processing. May be overriden by storage `ReservedXcmpWeightOverride` . If incoming messages in block will exceed the weight limit, they won’t be processed.
** `ReservedXcmpWeight` — default weight limit for the for the XCMP message processing. May be overridden by storage `ReservedXcmpWeightOverride` . If incoming messages in block will exceed the weight limit, they won’t be processed.
** `CheckAssociatedRelayNumber` — type that implements `trait CheckAssociatedRelayNumber` . Currently there are three implementations: no check (`AnyRelayNumber`), strict increase (`RelayNumberStrictlyIncreases`), monotonic increase (`RelayNumberMonotonicallyIncreases`). It is needed to maintain some order between blocks in relay chain and parachain.
** `ConsensusHook` — this is a feature-enabled config ( for the management of the xref:glossary.adoc#unincluded_segment[unincluded segment]. Requires the implementation of `trait ConsensusHook`. There are several implementations of it, in `parachain-system` crate (`FixedCapacityUnincludedSegment`) and in `aura-ext` crate (`FixedVelocityConsensusHook`). It is needed to maintain the logic of segment length handling.
* Common parameters for all pallets:
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/pallets/transaction_payment.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ The inputs are defined below in the glossary and config sections.
** `WeightToFee` -- Mapping between the smallest unit of weight and smallest unit of fee. Type must implement the trait `WeightToFee<Balance = BalanceOf<Self>>`.
** `LengthToFee` -- Convert a length value into a deductible fee based on the currency type. Type must implement the trait `WeightToFee<Balance = BalanceOf<Self>>`.
* Pallet-specific constants:
** `OperationalFeeMultiplier` -- A fee mulitiplier for `Operational` extrinsics to compute "virtual tip" to boost their `priority`. Type must implement the trait `Get<u32>`.
** `OperationalFeeMultiplier` -- A fee multiplier for `Operational` extrinsics to compute "virtual tip" to boost their `priority`. Type must implement the trait `Get<u32>`.
* Common configs:
** `RuntimeEvent`

Expand Down
2 changes: 1 addition & 1 deletion evm-template/node/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ pub enum Subcommand {

/// Try-runtime has migrated to a standalone
/// [CLI](<https://github.com/paritytech/try-runtime-cli>). The subcommand exists as a stub and
/// deprecation notice. It will be removed entirely some time after Janurary
/// deprecation notice. It will be removed entirely some time after January
/// 2024.
TryRuntime,
}
Expand Down
2 changes: 1 addition & 1 deletion evm-template/node/src/eth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pub fn db_config_dir(config: &Configuration) -> PathBuf {
config.base_path.config_dir(config.chain_spec.id())
}

/// Avalailable frontier backend types.
/// Available frontier backend types.
#[derive(Debug, Copy, Clone, Default, clap::ValueEnum)]
pub enum BackendType {
/// Either RocksDb or ParityDb as per inherited from the global backend settings.
Expand Down
2 changes: 1 addition & 1 deletion evm-template/runtime/src/constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pub mod currency {
pub const GRAND: Balance = 1_000 * DOLLARS;

/// NB: Notice, that existential deposit was set to 0 intentionally to increase compatibility with EVM.
/// Hovewer, it leads to some risks, most importantly state bloating.
/// However, it leads to some risks, most importantly state bloating.
/// We acknowledge that there is such a risk and we have an opened issue to resolve it:
/// https://github.com/OpenZeppelin/polkadot-runtime-templates/issues/195
/// If you read this message please check out this issue to see if it is resolved and what can you do to implement the fix.
Expand Down
2 changes: 1 addition & 1 deletion generic-template/node/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub enum Subcommand {

/// Try-runtime has migrated to a standalone
/// [CLI](<https://github.com/paritytech/try-runtime-cli>). The subcommand exists as a stub and
/// deprecation notice. It will be removed entirely some time after Janurary
/// deprecation notice. It will be removed entirely some time after January
/// 2024.
TryRuntime,
}
Expand Down

0 comments on commit ab8e657

Please sign in to comment.