Await .eventually test matchers
#54
Open
+68
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ernestognw
commented
Dec 27, 2024
arr00
reviewed
Dec 27, 2024
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
Amxx
reviewed
Dec 28, 2024
There was a problem hiding this comment.
This change is unrelated to the .eventually part. @frangio and I agreed that the forbiden first char could cause bad issues (not being able to sign some ERC-712 objects).
We can reopen that discussion, but not in this PR.
There was a problem hiding this comment.
The tests currently have multiple cases that include the forbidden first characters.
Are you ok removing those cases?
arr00
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
.eventuallychai matchers need to be awaited. From this, some issues raised. This PR fixes them