fix(uncache): consider both corrupt and denied when granting #4150
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From TileLink SPEC 1.9.3 Chapter7 "TileLink Uncached Lightweight (TL-UL)":
d_corrupt
is reserved and must be 0.d_corrupt
being HIGH indicates that masked data in this beat is corrupt.So it need consider both
d_denied
andd_corrupt
when geting the data.For uncache now, it complete in one beat, so there can execute
d_denied || d_corrupt
directly.