Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uncache): consider both corrupt and denied when granting #4150

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Maxpicca-Li
Copy link
Member

@Maxpicca-Li Maxpicca-Li commented Jan 8, 2025

From TileLink SPEC 1.9.3 Chapter7 "TileLink Uncached Lightweight (TL-UL)":

  • AccessAck: d_corrupt is reserved and must be 0.
  • AccessAckData, d_corrupt being HIGH indicates that masked data in this beat is corrupt.

So it need consider both d_denied and d_corrupt when geting the data.

For uncache now, it complete in one beat, so there can execute d_denied || d_corrupt directly.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 078bc55

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
078bc55 1.814 0.442 2.640 1.231 2.152 2.141 2.361 0.933 1.407 1.985 3.107 2.558 2.267 3.308

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
23767fc 1.814 0.442 2.640 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
14651e9 1.814 0.442 2.639 1.231 2.152 2.142 2.361 0.933 1.406 1.985 3.107 2.558 2.267 3.308
77733a7 1.814 0.442 2.640 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
da51a7a 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.407 1.985 3.107 2.558 2.267 3.308
c75efc0 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308

@Maxpicca-Li Maxpicca-Li marked this pull request as ready for review January 9, 2025 07:02
@linjuanZ linjuanZ merged commit db81ab7 into master Jan 9, 2025
9 checks passed
@linjuanZ linjuanZ deleted the fix-uncache-grant-2501 branch January 9, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants