Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LoadUnit): fast replay no longer requests to RAR/RAW Queue #4149

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Anzooooo
Copy link
Member

@Anzooooo Anzooooo commented Jan 8, 2025

For fast replay, there is no need to request access to the RAW/RAW Queue.
This prevents the RAW Queue from constantly ping-ponging between not full/full due to revoke.

These two lines were removed because it would lead to combinatorial logic loops and it was an unwanted condition:

!s2_rar_nack &&
!s2_raw_nack &&


Probably questions like this: #4102
With the previous changes plus this one, i don't think a similar stuck will happen again. 🙌

This may result in some performance gains.

@Anzooooo Anzooooo marked this pull request as ready for review January 8, 2025 06:51
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 886161b

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
886161b 1.823 0.442 2.639 1.237 2.159 2.145 2.361 0.940 1.407 1.931 3.107 2.556 2.272 3.308

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
23767fc 1.814 0.442 2.640 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
14651e9 1.814 0.442 2.639 1.231 2.152 2.142 2.361 0.933 1.406 1.985 3.107 2.558 2.267 3.308
77733a7 1.814 0.442 2.640 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308
da51a7a 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.407 1.985 3.107 2.558 2.267 3.308
c75efc0 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.403 1.985 3.107 2.558 2.267 3.308

@linjuanZ linjuanZ merged commit 1021e13 into master Jan 9, 2025
9 checks passed
@linjuanZ linjuanZ deleted the wzz-fast-unquery branch January 9, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants