fix(LoadUnit): fast replay
no longer requests to RAR/RAW Queue
#4149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
fast replay
, there is no need to request access to theRAW/RAW Queue
.This prevents the
RAW Queue
from constantly ping-ponging betweennot full/full
due torevoke
.These two lines were removed because it would lead to combinatorial logic loops and it was an unwanted condition:
XiangShan/src/main/scala/xiangshan/mem/pipeline/LoadUnit.scala
Lines 1269 to 1270 in dfc474e
Probably questions like this: #4102
With the previous changes plus this one, i don't think a similar stuck will happen again. 🙌
This may result in some performance gains.