Record "remote log" events #446
Open
+596
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DataLogger calls writeInfoToLog() every 60s * DataLogger sends an info string to SD_TC * DataLogger sends warning strings to SD_TC * Writes to EEPROM trigger DataLogger warnings * Include EEPROM values in DataLogger warnings * SD_TC writes alerts to SD card * Duplicate EEPROM writes don't warn DataLogger * New slope from PHProbe triggers DataLogger warning * thermal mean and std dev, more columns in alerts. * Alert filename in TankController.ino * Resolve EEPROM nan printing issues * Construct SD_TC without Ethernet_TC * WIP AlertPusher works but blocks, lacks tests * Changes related to alert file
* DataLogger calls writeInfoToLog() every 60s * DataLogger sends an info string to SD_TC * Reformat info string * DataLogger sends warning strings to SD_TC * Writes to EEPROM trigger DataLogger warnings * Include EEPROM values in DataLogger warnings * SD_TC writes alerts to SD card * Duplicate EEPROM writes don't warn DataLogger * New slope from PHProbe triggers DataLogger warning * thermal mean and std dev, more columns in alerts. * Alert filename in TankController.ino * WIP AlertPusher * Remove maximum size for logFileName * Add maximum size for logFileName * SD_TC::getAlert() * WIP AlertPusher * Resolve EEPROM nan printing issues * WIP tests * Construct SD_TC without Ethernet_TC * WIP AlertPusher somewhat functional * WIP AlertPusher works but blocks, lacks tests * Changes related to alert file * Tests run again
| @@ -1 +1 @@ | |||
| const String gitVersion = 'v24.3.2 +'; | |||
| const String gitVersion = 'v24.3.2-8-g9987+'; | |||
There was a problem hiding this comment.
What is the additional information?
test/PHProbeTest.cpp
Outdated
| @@ -167,14 +184,14 @@ unittest(settingMidpointClearsBadCalibration) { | |||
| unittest(setHighpointCalibration) { | |||
| GodmodeState *state = GODMODE(); | |||
| state->reset(); | |||
| eeprom->setIgnoreBadPHSlope(true); | |||
| assertTrue(eeprom->getIgnoreBadPHSlope()); | |||
| // eeprom->setIgnoreBadPHSlope(true); | |||
There was a problem hiding this comment.
Why the commented out code?
# Conflicts: # extras/device_client/lib/model/version.dart # src/Version.h
# Conflicts: # Makefile # examples/TankController/TankController.ino # extras/device_client/lib/model/version.dart # extras/log_file_client/lib/main.dart # extras/log_file_client/pubspec.yaml # src/TankController.cpp # src/TankController.h # src/Version.h # src/model/DataLogger.cpp # src/model/DataLogger.h # src/wrappers/SD_TC.cpp # src/wrappers/SD_TC.h # src/wrappers/ThermalProbe_TC.cpp # src/wrappers/ThermalProbe_TC.h # test/SDTest.cpp # test/ThermalControlTest.cpp # test/ThermalProbeTest.cpp
jgfoster
changed the title
# Conflicts: # extras/device_client/lib/model/version.dart # src/Version.h # src/model/DataLogger.cpp # src/model/DataLogger.h # src/wrappers/SD_TC.cpp # src/wrappers/SD_TC.h # test/SDTest.cpp
# Conflicts: # Makefile # extras/device_client/lib/model/version.dart # src/Version.h # src/model/DataLogger.cpp # src/wrappers/SD_TC.cpp # src/wrappers/SD_TC.h # test/DataLoggerTest.cpp # test/PHProbeTest.cpp # test/SDTest.cpp # test/SerialTest.cpp # test/TCLibTest.cpp # test/ThermalProbeTest.cpp
jgfoster
changed the title
* PushingBoxTest.cpp * RemoteLogPusherTest.cpp # Conflicts: # extras/device_client/lib/model/version.dart # src/TankController.cpp # src/Version.h # src/model/JSONBuilder.cpp # test/PushingBoxTest.cpp
# Conflicts: # Makefile # extras/device_client/lib/model/version.dart # src/TankController.cpp # src/Version.h # src/model/RemoteLogPusher.cpp # src/model/RemoteLogPusher.h # src/wrappers/EEPROM_TC.cpp # src/wrappers/SD_TC.cpp # test/RemoteLogPusherTest.cpp
- Use tabs instead of spaces in Makefile. - Fix format error.
- Remove duplicates from Makefile.
# Conflicts: # extras/device_client/lib/model/version.dart # src/Version.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to storing one-second data on the SD card, we store one-minute events and (plan to) upload that file to oap.cs.wallawalla.edu where it can be used by a web application to show log files.