Inject custom entries to the OctopusContainer environment #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
changed the title
kevjt
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates an avenue for injecting feature-flags into the OctopusServer container (which cannot currently be done).
This change allows the consumer of the OctopusContainerTest object to inject both a version and also custom environment variables (or any combination thereof).
If a version is not provided - the version-selector falls back on the environment, then otherwise provides "latest' (as per prior behaviour).
The CustomEnvironment variables are used to extend the values passed into the Container creation request - but will not overwrite existing values.